SIO-ODF / ctdcal

A CTD calibration package in use on US GO-SHIP cruises
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

2024 qc fixes #124

Closed Klankers closed 2 months ago

Klankers commented 2 months ago

Restores enhancements from various branches, including multiple params in the table, new residuals, a residuals plot.

Fixed a few bugs.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.86207% with 122 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ctdcal/tools/data_qc.py 0.00% 47 Missing :warning:
ctdcal/oxy_fitting.py 3.33% 29 Missing :warning:
ctdcal/process_bottle.py 3.44% 28 Missing :warning:
ctdcal/odf_io.py 37.93% 11 Missing and 7 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
pytest 29.63% <15.86%> (-4.25%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ctdcal/config.py 100.00% <ø> (ø)
ctdcal/convert.py 10.21% <ø> (ø)
ctdcal/equations_sbe.py 97.29% <100.00%> (+0.26%) :arrow_up:
ctdcal/odf_io.py 72.72% <37.93%> (-8.59%) :arrow_down:
ctdcal/process_bottle.py 22.13% <3.44%> (-2.32%) :arrow_down:
ctdcal/oxy_fitting.py 16.38% <3.33%> (-1.21%) :arrow_down:
ctdcal/tools/data_qc.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

asmith75218 commented 2 months ago

The ten files changed I currently see appear to mostly be from PR #123. I'll hold off until that one is merged.