Previous methods in soak detection used the pump_status_on and varying values in the CTD pressure to detect when the CTD hit the water and when the CTD finished soaking. They were not well-organized and should be redistributed into the processors.
The alternative method is good, but hasn't been proven to be "best". It's important to keep the old ODF methods functional and test them side-by-side with the new methods, especially in the context of IAPSO algorithms or institutional/manufacturer preferences.
An example of a pump hiccup is in the GP17-ANT branch (comment on a particular cast).
During the refactor, they'll be moved around. Could slide into next milestone.
Previous methods in soak detection used the
pump_status_onand varying values in the CTD pressure to detect when the CTD hit the water and when the CTD finished soaking. They were not well-organized and should be redistributed into the processors.process_ctd._trim_soak_periodprocess_ctd._find_last_soak_periodThe alternative method is good, but hasn't been proven to be "best". It's important to keep the old ODF methods functional and test them side-by-side with the new methods, especially in the context of IAPSO algorithms or institutional/manufacturer preferences.
An example of a pump hiccup is in the GP17-ANT branch (comment on a particular cast).
During the refactor, they'll be moved around. Could slide into next milestone.