search

SMAT-Lab / Scalpel

Scalpel: The Python Static Analysis Framework
Apache License 2.0
286 stars 43 forks source link

Patch bug: missing finally block in try-except structures #100

Closed samuelchassot closed 1 year ago

samuelchassot commented 1 year ago

solves #98 I'll add tests

Jarvx commented 1 year ago

@samuelchassot Thanks for the help. Would you mind submit this PR to this branch https://github.com/SMAT-Lab/Scalpel/tree/scalpel-CFG-for-final-clause.

It takes a much longer time to review changes for the main branch. For sure, this contribution will be merged into the next release.

samuelchassot commented 1 year ago

With pleasure :) Yes, sure, I'll make the modification tomorrow when I'll add a test.

samuelchassot commented 1 year ago

Let me know if any changes are needed :)

Jarvx commented 1 year ago

Thanks for fixing the problem and adding so many test cases. I just realized the code I've written down before is very chaotic. I will refactor the CFG again and make it into the release branch soon. Please feel free to submit any issue reports.

samuelchassot commented 1 year ago

You're welcome! I see, that's great!