SMAT-Lab / Scalpel

Scalpel: The Python Static Analysis Framework
Apache License 2.0
295 stars 46 forks source link

Write uniform tests #81

Closed simisimon closed 1 year ago

simisimon commented 2 years ago

I looked into different test files and found different ways how tests were written. For example, some tests rely on pytest and other not. In my opinion, this is not a good practice. Usually, python projects employ a specific test frameworks to write small and readable tests. Moreover, a testing framework helps to keep tests readable and maintainable. So far, that is not the case for Scalpel. Hence, I would recommend to integrate a specific testing framework for all tests and write a short guideline how tests should be written in order to have uniform tests.

I think pytest is already a suitable framework that should be used in all tests. With pytest, you can also use GitHub actions to test your project whenever changes are pushed.

Jarvx commented 2 years ago

Thanks for pointing this out. You are absolutely correct, I am working on adding some new functionalities at the moment. Hopefully will address this issue in Sept, we will also see a new release version of the project then.