search

SORSE / sorse.github.io

Website of the SORSE20 conference
https://sorse.github.io
Creative Commons Attribution 4.0 International
4 stars 14 forks source link

preview for website? #29

Closed vsoch closed 4 years ago

vsoch commented 4 years ago

hey @sdruskat and @Chilipp - I think it might be really useful to have static previews of the site, to make reviewing of the PRs easier. What do you think? If you want to connect the repository to circle, I can take a shot at adding a build that saves static files for preview (we do it for usrse).

Chilipp commented 4 years ago

Hey @vsoch ! I think that's a great idea :) I never used circle for automatic deployment but I suppose you have to allow access at the organization level (which is something I cannot do, but @sdruskat can) and you can only builds for one private repository. Am I correct?

An alternative would be to use GitHub actions. Do you have any experience with that? I am agnostic about the CI service and from my experience they are all easy to setup for such a setting. But as all of them require permissions on the organization level, this is not something that I can decide.

vsoch commented 4 years ago

GitHub Actions would allow artifacts, but you would have to download and then extract and start a web server to preview. It's actually harder than just pulling and running jekyll serve, so I wouldn't recommend it over circle (where you can just click and see the preview in the browser).

Chilipp commented 4 years ago

Alright, didn't know that. Then yes, +1 for circle from my side :)

sdruskat commented 4 years ago

Yes, sure, I'll set up Circle for this repo.

sdruskat commented 4 years ago

Board agreed to have Circle activated, so I did :)

vsoch commented 4 years ago

Closed with #30