SRGSSR / pillarbox-android

The modern SRG SSR Pillarbox player targeting Android platforms
https://android.pillarbox.ch/api
MIT License
13 stars 1 forks source link

Bump android-gradle-plugin from 8.3.2 to 8.4.0 #523

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 6 months ago

Bumps android-gradle-plugin from 8.3.2 to 8.4.0. Updates com.android.tools.build:gradle-api from 8.3.2 to 8.4.0

Updates com.android.application from 8.3.2 to 8.4.0

Updates com.android.library from 8.3.2 to 8.4.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
github-actions[bot] commented 6 months ago

Code Coverage

Overall Project 48.63% 🟢

There is no coverage information present for the Files changed

MGaetan89 commented 6 months ago

This doesn't seem to break the app, but it generates a bunch of new warnings during build:

Warning: Failed to fetch URL https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml/sys-img.xml, reason: File not found
Warning: Errors during XML parse:
Warning: https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml parsing problem. unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: javax.xml.bind.UnmarshalException: unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: Additionally, the fallback loader failed to parse the XML.

We can merge it as is, if the app is indeed working as expected, or wait for version 8.4.1. In both cases, I suggest to wait until after the next release.

MGaetan89 commented 5 months ago

@dependabot rebase

MGaetan89 commented 5 months ago

This doesn't seem to break the app, but it generates a bunch of new warnings during build:

Warning: Failed to fetch URL https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml/sys-img.xml, reason: File not found
Warning: Errors during XML parse:
Warning: https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml parsing problem. unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: javax.xml.bind.UnmarshalException: unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: Additionally, the fallback loader failed to parse the XML.

We can merge it as is, if the app is indeed working as expected, or wait for version 8.4.1. In both cases, I suggest to wait until after the next release.

Looks like this is similar to the following issue: https://issuetracker.google.com/issues/337761982.

However, the app seems to be working as expected and the build passes, so I guess we can merge it, now that version 2.0.0 was released.