SRGSSR / pillarbox-android

The modern SRG SSR Pillarbox player targeting Android platforms
https://android.pillarbox.ch/api
MIT License
13 stars 1 forks source link

Update AndroidX Compose #698

Closed MGaetan89 closed 1 month ago

MGaetan89 commented 1 month ago

Pull request

Description

This PR updates Pillarbox to use Compose 2024.09.00 (1.7.0 and Material3 1.3.0).

Changes made

[!NOTE] It seems that new versions of Compose Material Navigation were not released after 1.7.0-beta01, and went straight to version 1.8.0-alpha01, and it is also missing from the BOM. I've used 1.7.0-beta01 to be as close to the Compose version as possible. Since it is only used in the demo apps, I think it is fine to use a beta dependency. Let me know if you prefer to keep Accompanist Navigation Material (which is now deprecated) until a stable version of Compose Material Navigation is released. Here's a ticket on Google side: https://issuetracker.google.com/issues/347719428

Checklist

github-actions[bot] commented 1 month ago

Code Coverage

Overall Project 45.15% 🟢
Files changed 0% 🟢


Module Coverage
:pillarbox-player 51.12% 🟢
:pillarbox-ui 0.06% -0.02% 🟢
Files |Module|File|Coverage|| |:-|:-|:-|:-:| |:pillarbox-player|[PlayerCallbackFlow.kt](https://github.com/SRGSSR/pillarbox-android/blob/8fd3b5d10479e1c33a7e99d45ac5c0c4eb8b7843/pillarbox-player%2Fsrc%2Fmain%2Fjava%2Fch%2Fsrgssr%2Fpillarbox%2Fplayer%2FPlayerCallbackFlow.kt)|71.62%|🟢| |:pillarbox-ui|[PlayerSurface.kt](https://github.com/SRGSSR/pillarbox-android/blob/8fd3b5d10479e1c33a7e99d45ac5c0c4eb8b7843/pillarbox-ui%2Fsrc%2Fmain%2Fjava%2Fch%2Fsrgssr%2Fpillarbox%2Fui%2Fwidget%2Fplayer%2FPlayerSurface.kt)|0.33%|🟢| ||[SphericalSurface.kt](https://github.com/SRGSSR/pillarbox-android/blob/8fd3b5d10479e1c33a7e99d45ac5c0c4eb8b7843/pillarbox-ui%2Fsrc%2Fmain%2Fjava%2Fch%2Fsrgssr%2Fpillarbox%2Fui%2Fwidget%2Fplayer%2FSphericalSurface.kt)|0%|🟢| ||[ExoplayerSubtitleView.kt](https://github.com/SRGSSR/pillarbox-android/blob/8fd3b5d10479e1c33a7e99d45ac5c0c4eb8b7843/pillarbox-ui%2Fsrc%2Fmain%2Fjava%2Fch%2Fsrgssr%2Fpillarbox%2Fui%2Fexoplayer%2FExoplayerSubtitleView.kt)|0%|🟢| ||[DelayedVisibilityState.kt](https://github.com/SRGSSR/pillarbox-android/blob/8fd3b5d10479e1c33a7e99d45ac5c0c4eb8b7843/pillarbox-ui%2Fsrc%2Fmain%2Fjava%2Fch%2Fsrgssr%2Fpillarbox%2Fui%2Fwidget%2FDelayedVisibilityState.kt)|0% **`-0.13%`**|🟢|
StaehliJ commented 1 month ago

Sounds good for me to use beta version in demo application modules.