SRGSSR / pillarbox-android

The modern SRG SSR Pillarbox player targeting Android platforms

https://android.pillarbox.ch/api

MIT License

13 stars 1 forks source link

Update to AndroidX Navigation 2.8.0 #701

Closed MGaetan89 closed 1 month ago

MGaetan89 commented 1 month ago

Pull request

Description

This PR updates to AndroidX Navigation 2.8.0. The changelog is available here.

Changes made

Update to AndroidX Navigation 2.8.0.
Migrate NavHost to use type-safe navigation.

Hopefully, future versions of AndroidX Navigation will simplify things a bit:

Support property level @Serializable (see b/348468840): with that we should be able to remove the buName workaround in ContentList.
Support compsable(KClass) (in addition to composable<Route>) (see b/361863272): this should allow us to remove the addContentListRoute function in both ListsHome files (in pillarbox-demo and pillarbox-demo-tv).

Checklist

[x] Your branch has been rebased onto the main branch.
[ ] APIs have been properly documented (if relevant).
[ ] The documentation has been updated (if relevant).
[ ] New unit tests have been written (if relevant).
[x] The demo has been updated (if relevant).
[x] All pull request status checks pass.

github-actions[bot] commented 1 month ago

Code Coverage

Overall Project	50.1%	🟢

There is no coverage information present for the Files changed

MGaetan89 commented 1 month ago

Sounds goods but still on the TV, when selecting an item in the player settings, it closed immediatly.

Yes, I've opened a dedicated ticket for that: https://github.com/SRGSSR/pillarbox-android/issues/702