Closed MGaetan89 closed 2 weeks ago
Overall Project | 48.48% -0.42% |
π’ |
---|---|---|
Files changed | 62.9% | π’ |
Module | Coverage | |
---|---|---|
:pillarbox-player | 58.06% -0.19% |
π’ |
:pillarbox-ui | 0.2% -1.49% |
π’ |
Looks good to me ππ»
@StaehliJ I can't approve it, since I opened the PR. Feel free to approve it, then we can merge it. I just pushed a couple small changes https://github.com/SRGSSR/pillarbox-android/pull/726/commits/1a1a9fe0c198498dbcb27b9f2d3b4c6a87b77f8b
I've switched the runner for the Android Tests step to ubuntu-22.04
. See https://github.com/SRGSSR/pillarbox-android/pull/736#issuecomment-2407408319 for more details.
Looks like Google will make it easier to share parameters between the DefaultPreloadManager
and ExoPlayer
in the next version: https://github.com/androidx/media/commit/98dc7f2def8b7404383a118d02f309870a5bede4
I've reverted my change to the runner. See https://github.com/SRGSSR/pillarbox-android/issues/747#issuecomment-2410190157
Pull request
Description
This PR introduces a
PillarboxPreloadManager
and related classes. It also updates theOptimizedStory
to use this new helper.The
PillarboxPreloadManager
takes the same arguments asDefaultPreloadManager
/PillarboxExoPlayer
, with the addition of aPlayerPool
. This allowsPillarboxPreloadManager
to create player on-demand, and reuse them if needed.Changes made
PillarboxPreloadManager
.PlayerPool
.PillarboxPreloadManager
.PillarboxRenderersFactory
.PillarboxTrackSelector
.StoryViewModel
to use the newPillarboxPreloadManager
.OptimizedStory
to scroll vertically instead of horizontally.StringUtil
inSimplePlayerViewModel
.Checklist
main
branch.