SRGSSR / pillarbox-android

The modern SRG SSR Pillarbox player targeting Android platforms

https://android.pillarbox.ch/api

MIT License

13 stars 1 forks source link

Move Monitoring configuration to `pillarbox-core-business` #743

Closed MGaetan89 closed 3 weeks ago

MGaetan89 commented 3 weeks ago

Pull request

Description

This PR makes Monitoring an opt-in feature.

Changes made

Change PillarboxExoPlayer to use NoOpMonitoringMessageHandler by default.
Change DefaultPillarbox to use RemoteMonitoringMessageHandler in debug, and LogcatMonitoringMessageHandler in release.
Configure Monitoring in PlayerModule.
Update pillarbox-core-business documentation.
Update pillarbox-player documentation.

Checklist

[x] Your branch has been rebased onto the main branch.
[x] APIs have been properly documented (if relevant).
[x] The documentation has been updated (if relevant).
[ ] New unit tests have been written (if relevant).
[ ] The demo has been updated (if relevant).
[ ] All pull request status checks pass.

github-actions[bot] commented 3 weeks ago

Code Coverage

Overall Project	48% `-0.15%`	🟢
Files changed	6.38%	🟢

Module	Coverage
:pillarbox-core-business	79.8% `-0.84%`	🟢
:pillarbox-player	57.68%	🟢

Files

|Module|File|Coverage|| |:-|:-|:-|:-:| |:pillarbox-core-business|[DefaultPillarbox.kt](https://github.com/SRGSSR/pillarbox-android/blob/2a719e90758c47dc759bf99005f112c6bc659a7f/pillarbox-core-business%2Fsrc%2Fmain%2Fjava%2Fch%2Fsrgssr%2Fpillarbox%2Fcore%2Fbusiness%2FDefaultPillarbox.kt)|0% **`-29.14%`**|🟢| |:pillarbox-player|[PillarboxExoPlayer.kt](https://github.com/SRGSSR/pillarbox-android/blob/2a719e90758c47dc759bf99005f112c6bc659a7f/pillarbox-player%2Fsrc%2Fmain%2Fjava%2Fch%2Fsrgssr%2Fpillarbox%2Fplayer%2FPillarboxExoPlayer.kt)|80.15%|🟢|