SRGSSR / pillarbox-android

The modern SRG SSR Pillarbox player targeting Android platforms

https://android.pillarbox.ch/api

MIT License

13 stars 1 forks source link

Let the user input any value for the media URL/URN #773

Closed MGaetan89 closed 2 days ago

MGaetan89 commented 2 days ago

Pull request

Description

Don't crash the demo app when entering a value that is neither a URL nor a URN in the input field in "Examples".

Changes made

In the event that the provided value is neither a value URL nor a valid URN, we now treat it as a URL, without the license URL. This aligns the behavior with what is done in the Apple and Web demos.

Checklist

[ ] APIs have been properly documented (if relevant).
[ ] The documentation has been updated (if relevant).
[ ] New unit tests have been written (if relevant).
[x] The demo has been updated (if relevant).

github-actions[bot] commented 2 days ago

Code Coverage

Overall Project	47.96%	🟢

There is no coverage information present for the Files changed

MGaetan89 commented 2 days ago

Ideally we should prompt user that it is invalid. But I'm okay with the fix.

That was my initial idea, but in the end, I decided to align with what is done on Apple and the Web.