SRGSSR / pillarbox-apple

A next-generation reactive media playback ecosystem for Apple platforms.

https://testflight.apple.com/join/TS6ngLqf

MIT License

45 stars 6 forks source link

Avoid settings menu being closed when controls disappear #883

Closed defagos closed 2 weeks ago

defagos commented 2 weeks ago

Description

This PR fixes a minor regression introduced in #881, in which bottom buttons (including the settings menu button) were removed from the hierarchy with hidden controls.

Due to current limitations with SwiftUI Menu API (see #384) we currently cannot prevent controls from disappearing while the menu is open. As a result the change in #881 was closing the menu while the user was picking a speed or tracks during playback. To reproduce:

Open the demo nightly build 429.
Play the first SWI video example. Do not pause playback.
Open the settings menu and wait. The menu is dismissed when controls are hidden.

Changes made

Use opacity to hide bottom bar buttons while in full-screen layout.

Checklist

[x] APIs have been properly documented (if relevant).
[x] The documentation has been updated (if relevant).
[x] New unit tests have been written (if relevant).
[x] The demo has been updated (if relevant).

waliid commented 2 weeks ago

Thanks! I really appreciate this iteration.