search

SRGSSR / pillarbox-apple

A next-generation reactive media playback ecosystem for Apple platforms.
https://testflight.apple.com/join/TS6ngLqf
MIT License
51 stars 7 forks source link

Crashes due to chapter URN absence in metadata #955

Open defagos opened 1 month ago

defagos commented 1 month ago

Is there an existing issue for this?

Description of the problem

Checking SRF News crash reports with Xcode we found a few issues related to Pillarbox. These should be further investigated.

This issue is related to a force unwrap assuming that a chapter matching a chapter URN is always available in a media composition. Well, it seems that sometimes this breaks for some reason.

Crash logs are attached to this issue.

Relevant stack trace or log output

No response

Reproducibility

Difficult

Steps to reproduce

None yet. We don't know which URN had this problem.

Library version

2.0.0

Operating system

Any

Code sample

No response

defagos commented 1 month ago

Maybe we could avoid the force unwrap here but the cost of this change needs to be investigated, as this situation should never occur in practice.

If changes required are too ugly I would suggest we live with it. This will vanish once our new backend is in place.

defagos commented 1 month ago

I thought about another option: Generating a dummy chapter with a blocking reason if for some reason the chapter is missing.

Not sure this is a great idea, though, especially since we probably will display metadata for unavailable content in the future, see #918.