SRI-International / QC-App-Oriented-Benchmarks

QED-C: The Quantum Economic Development Consortium provides these computer programs and software for use in the fields of quantum science and engineering.
Apache License 2.0
143 stars 80 forks source link

"Default Noise Model in execute.py incorrectly uses depolarizing_error for amplitude_damping_error #475

Open GIRISHBELANI opened 5 months ago

GIRISHBELANI commented 5 months ago
# Add amplitude damping error to all single qubit gates with error rate 0.0%
#                         and to all two qubit gates with error rate 0.0%
amp_damp_one_qb_error = 0.0
amp_damp_two_qb_error = 0.0
noise.add_all_qubit_quantum_error(depolarizing_error(amp_damp_one_qb_error, 1), ['rx', 'ry', 'rz'])    #line number = 193
noise.add_all_qubit_quantum_error(depolarizing_error(amp_damp_two_qb_error, 2), ['cx'])                 #line number = 194
rtvuser1 commented 1 month ago

Yes, that does not look right. Can you suggest a simple change that would fix this?

GIRISHBELANI commented 1 month ago

Instead of using depolarizing_error(), we can opt for amplitude_damping_error(). However, it only applies to single-qubit errors, as amplitude_damping_error() returns a quantum error channel specific to single-qubit generalized amplitude damping. Therefore, it cannot be directly applied to a two-qubit error model like amp_damp_two_qb_error.