STAT545-UBC-hw-2018-19 / hw01-JasmineLib

hw01-JasmineLib created by GitHub Classroom
0 stars 0 forks source link

Peer review hw01 #2

Open RetoSterchi opened 6 years ago

RetoSterchi commented 6 years ago

Peer review hw-01 for JasmineLib

TOPIC Excellent Satisfactory Needs work Comments
Coding style ✔️ I liked the idea of linking external resources (e.g., how to make boxplots) while reading through your code
Coding strategy :heavy_check_mark: Always great to double-check the output of a function with a solution that is calculated manually (e.g., variance in your example)
Presentation: graphs :heavy_check_mark: Adequate graphs for exploring basic properties of dataset
Presentation: tables :heavy_check_mark: Well, there is actually no table in the R code but the 'to-do-list' in the Readme file is awesome! :bookmark_tabs:
Achievement, creativity :heavy_check_mark: Excellent use of emojies :trophy:
Ease of access :heavy_check_mark: Great job on the very well documented readme file. The link to the the relevant files made reviewing a very straight forward task

Suggestions for future coding:

str(iris)

'data.frame':   150 obs. of  5 variables:
 $ Sepal.Length: num  5.1 4.9 4.7 4.6 5 5.4 4.6 5 4.4 4.9 ...
 $ Sepal.Width : num  3.5 3 3.2 3.1 3.6 3.9 3.4 3.4 2.9 3.1 ...
 $ Petal.Length: num  1.4 1.4 1.3 1.5 1.4 1.7 1.4 1.5 1.4 1.5 ...
 $ Petal.Width : num  0.2 0.2 0.2 0.2 0.2 0.4 0.3 0.2 0.2 0.1 ...
 $ Species     : Factor w/ 3 levels "setosa","versicolor",..: 1 1 1 1 1 1 1 1 1 1 ...

Cheers, Reto

JasmineLib commented 6 years ago

Hey Reto,

Thanks for all the help and feedback, I really appreciate it! Your suggestions will be useful in the future.

Jasmine

Jasmine