tsmith93
commented
5 years ago One more thing I forgot to mention is that there did not appear to be any instructions of how I could actually download your package. It would be nice for someone learning about your package to give it a test drive!
But again, I thought you did a fantastic job with this :)
Hi Laura,
I had the pleasure of reviewing your homework 7! In this issue, I just wanted to give you some feedback on what I liked, and what you might want to consider for the future.
Overall, I really liked the organization of your assignment. Your README let me know what to expect and gave me easy access to the main component of your homework. The md file was well written, and you went above and beyond with explaining the Box-Cox transformation. I also like how your incorporated all of the requirements of your homework into this file, making it easy to walk through. As well, including figures made it easy to understand exactly what the box-cox transformation achieved. I also like how you made sure to include all of the code in your md file, allowing me to see exactly what you did with the function creation and for the tests. At first, I was confused because you couldn't actually open your powers folder, but in the end all of the required material was still shown in the .md file. Though, for the future, I think it would be really useful to allow people visiting your repository to access the package folder.
Overall, great job!