TA feedback for hw04

[wvictor14]

Hi Belal,

Great work overall, here is some feedback:

• Note that the readability of this block of code can be improved. Mostly, be conscious of when a new line is tabbed or not tabbed. Usually, a tabbed line signifies that this code is part of the above function call / piping chain. So you have something like this:

email.new <- email %>% 
  separate_rows(guest, sep = ", ") %>% 
  rename(name = guest)

  guest.new <- guest %>% 
  left_join(email.new, by = "name") 
  DT::datatable(guest.new)

• Which could be improved by removing the the tabs/spaces on those lines where a new function / pipe chain is called:

email.new <- email %>% 
  separate_rows(guest, sep = ", ") %>% 
  rename(name = guest)

guest.new <- guest %>% 
  left_join(email.new, by = "name") 

DT::datatable(guest.new)

This is just a best practices thing that helps more than you might think, especially when your scripts become much longer. I just wanted to comment on this since I saw that you are using tabs a lot in your homework.

Cheers, Victor