STEMMechanics / STEMCraft-Core

The core plugin that runs the STEMCraft Minecraft Server
https://www.stemcraft.com.au
MIT License
1 stars 1 forks source link

add "blank" music discs that can be burned with pv-addon-discs #73

Open ProjectHSI opened 7 months ago

ProjectHSI commented 7 months ago

basically a more achievable way of getting music discs to burn without too much effort. maybe something like they spawn in villages or can be craftable. the music discs by themselves can't be played but can be burned and then played with pv-addon-discs

ProjectHSI commented 7 months ago

code that deals with checking music discs for burn ellgibility https://github.com/plasmoapp/pv-addon-discs/blob/5c59b459f39192c1372a61320b1887f2d00c0957/src/main/kotlin/su/plo/voice/discs/command/subcommand/BurnCommand.kt#L62

ProjectHSI commented 7 months ago

Eligibility is determined by an item's persistent data container.

https://github.com/plasmoapp/pv-addon-discs/blob/5c59b459f39192c1372a61320b1887f2d00c0957/src/main/kotlin/su/plo/voice/discs/DiscsPlugin.kt#L55

nomadjimbob commented 7 months ago

The idea of 'survival towns' is to have vendors (including the spawn town). We could have a vendor sell these blank discs and a second vendor which requests a url to burn onto the disc through chat?

ProjectHSI commented 7 months ago

2nd vendor idea sounds neat. Are you saying the 2nd vendor replaces the command or supplements it with an abstraction?

nomadjimbob commented 7 months ago

Replaces the command (runs the command on behalf of the player, or the plugin does what it needs to do to make it work). Mods would have the command to override if needed.

I started a SMShopKeeper Citizens trait in the 1.5 plugin but will prob be a 1.6 addition

ProjectHSI commented 7 months ago

Alright. I think we should have the command available for non-survival worlds (creative plots specifically)

nomadjimbob commented 7 months ago

Yep. We can enable it the command like we do with worldedit with gamemode=creative. Allows testing in the creative world, and mods to explicitly have to change gamemodes in survival worlds to use the command

ProjectHSI commented 7 months ago

Cost: Bronze to buy a blank disc and erase a disc Iron to burn a blank disc