search

SaifAqqad / AHK_MicMute

Control your microphone using keyboard and mouse hotkeys.
The Unlicense
181 stars 14 forks source link

High visibility icons #65

Closed Reenuip closed 2 years ago

Reenuip commented 2 years ago

I made edits of the original muted/unmuted status icons for better visibility. The microphone is larger and is striked out with a thick red line when muted.

SaifAqqad commented 2 years ago

Thank you for the PR, the icon looks great.

Although I think it should have a thin dark outline so it's more visible on white backgrounds, as you can see in the screenshot below it's barely visible image

Reenuip commented 2 years ago

Sure, I could definitely give the whole thing an outline, but it might not look great in the system tray at 16x16px unless I make a pixel-perfect version. If that turns out to be necessary, you may want to consider using different resources for the OSD microphone icon and the system tray. I was under the impression that the dark icons in the Resources folder were used in certain configurations, but I haven't found where they're used. Maybe we could expose some toggle in the UI between the light and dark icons. Either way, I'll soon get around to making some changes to the base icons and play with different scales.

SaifAqqad commented 2 years ago

Yeah, I think I'll need to use separate icons for the overlay, also might as well add the option to choose between light and dark in that case.

currently, the black icon is only used for the tray and only when windows 10/11 is set to light mode.

Reenuip commented 2 years ago

Sounds good. I already made a vector version of the base microphone, so I can crank out the different sizes in a bit. What is the size of the overlay version? Been searching through the scripts, but I can't find the spec.

SaifAqqad commented 2 years ago

What is the size of the overlay version? Been searching through the scripts, but I can't find the spec.

The overlay's icon is 48x48

Since I'm gonna separate the overlay icon from the tray icon, you can just make an ico with a single 48x48 image for the overlay (with an outline), and another ico with different sizes (16x16 32x32) for the tray (without any outline)

The outline could be dark grey for the light icon, and light grey for the dark icon

Reenuip commented 2 years ago

Sounds good, Saif. I'll get working on those later tonight. Thanks for the info!

SaifAqqad commented 2 years ago

Thank you, the icons look great, I will merge this now.

I'm gonna work on the overlay though, I'm looking into using Gdip to render the icon because the rendering looks really awful right now image

roughnecks commented 2 years ago

yeah, overlay is all grainy/blurred, looks low res or something.

SaifAqqad commented 2 years ago

I can confirm Gdip does indeed fix the issue image image

Reenuip commented 2 years ago

I can confirm Gdip does indeed fix the issue

Cool. I was about to experiment with a transparent background to see if that helps, but this is looking very nice.

SaifAqqad commented 2 years ago

@Reenuip sorry for the delay (I was busy with other stuff). I have pushed the new overlay, you can test it out in the pre-release version if you want, I still need to add the new overlay options to the config UI though