search

SalvieMundi / DefinitiveEditionVanillaPlus

The Minecraft Vanilla+ Definitive Edition Modpack
1 stars 0 forks source link

not sure how or why, but a grave didnt spawn when I died #26

Closed Tigerboy007 closed 2 years ago

SalvieMundi commented 2 years ago

Got the coords for that?

Tigerboy007 commented 2 years ago

ah, not any more no I left the game

Tigerboy007 commented 2 years ago

I can get aproximate ones?

SalvieMundi commented 2 years ago

Yes pls. :3

Tigerboy007 commented 2 years ago

approximately 0, -17, 137

Tigerboy007 commented 2 years ago

oh, and it was death by creeper if that matters

SalvieMundi commented 2 years ago

Might. Possibly, marker was blown up by the ensuing explosion.

SalvieMundi commented 2 years ago

According to the Server Log, marker spawned at y 11

[19:13:53] [Server thread/INFO]: [STDOUT]: [Markers] Marker spawned at: 0, 11, 136

SalvieMundi commented 2 years ago

Lines 99 - 101 of https://github.com/ginsm/notforgotten/blob/main/src/main/java/net/gleam/markers/Markers.java

if(blockPos.getY() < 0) { blockPos = new BlockPos(blockPos.getX(), 10, blockPos.getZ()); }

Likely done to prevent the void from filling with markers and creating a laggy server mess. However, 1.17 + Datapack onward will have a bottom of -64. Changing to this should fix:

if(blockPos.getY() < world.getBottomY()) { blockPos = new BlockPos(blockPos.getX(), world.getBottomY() + 10, blockPos.getZ()); }

SalvieMundi commented 2 years ago

fixed on my personal server, will commit up to github shortly

Tigerboy007 commented 2 years ago

Ah! thanks!