Refactor change DB collections used for Issue #266

SamanthaGuillemette / SOEN390

SOEN390 Project

MIT License

5 stars 0 forks source link

Refactor change DB collections used for Issue #266 #269

Closed smarkandu closed 2 years ago

smarkandu commented 2 years ago

Covers Issue #266

Things to note:

I had to fix the code to take "null" values into account. For example, if the "status" attribute doesn't exist, it's assumed to be "Unconfirmed", etc.
I had to change the Client app to store the date of birth in the format specified in: https://www.w3schools.com/js/js_date_formats.asp This is in order to be able to create a "Date" object from the given dob string stored in the DB. After Friday, we should manually change the dob strings for existing Client and Admin objects to have this format. Anything "new" created uses this format.

tusharraval102 commented 2 years ago

After running the code, I think the everything looks good. I do have a few things to suggest:

• The doctor dropdown should be searchable and scrollable. • Maybe we should not show the symptoms list when it is "undefined" and we can show a message instead (it might be cleaner)

smarkandu commented 2 years ago

After running the code, I think the everything looks good. I do have a few things to suggest:

• The doctor dropdown should be searchable and scrollable. • Maybe we should not show the symptoms list when it is "undefined" and we can show a message instead (it might be cleaner)

This is a refactor to switch the tables, and not to improve features. We can do that with another PR. They're good points though, and we can address them once this PR is done. Symptoms is not currently being retrieved from the DB.