Doctor sigup successfully even with an invalid birthday

[liuwei-tianshu]

Reproduce steps on admin: 1 signup as a doctor with an invalid birthday, it "looks" like the doctor signs up successfully 2 I label it as a high priority because when that doctor signs in again, there will be an error message. 3 Also, sometimes when I input an invalid birthday, there is no prompt.

You can either remove the validation of birthday or implement it well. Please assign one or two QA to test the application carefully.

Sometimes, you can assign everyone to test it. The testing is HUGE work!

[AliZ786]

Thank you for bringing this to our attention @liuwei-tianshu

[liuwei-tianshu]

The system is not friendly to use now.

There are still minor defects: 1 My personal thinking is that it is not a good idea to implement the system as a "black" model regarding health. I thought the system provides several choices of color models for clients to select. However, the "black" model is the only one. We usually use blue, green, etc. colors to make people feel conformable regarding health. Just my own opinion. It is not a big problem and your team can make a decision about it by yourself. We as clients focus more on the usage of the system.

2 a minor problem Perhaps you can refer to the demo site of Solidus on GitHub: https://github.com/solidusio/solidus#demo Actually, all of these systems are similar even they are in different domains. You can find a lot of these systems on GitHub by searching: eCommerce, CRM, ERP, forum ...

3 I was wondering you can let someone who is not familiar with it try to use the system. I believe there will be more defects be found by real clients.

4 Also, please provide a simple description of how to use it on README. People may do not understand what is the patient portal or admin portal. They may also do not understand how to use the patient portal in a mobile phone browser or in chrome.

5 In a word, please test it more by QAs.

[smarkandu]

Hi sir, I saw your comment regarding the justification of this bug as "high priority":

"I label it as a high priority because when that doctor signs in again, there will be an error message."

Yet in the animated gif you posted, I didn't see an error. Nor were we able to repro any error using the date you used.

Also, shouldn't "high priority" only be used for cases where a bug causes the system to crash, etc? In this case, it just seems to be a case of bad data, which doesn't hinder the app in terms of stability, etc

[liuwei-tianshu]

Hi sir, I saw your comment regarding the justification of this bug as "high priority":

"I label it as a high priority because when that doctor signs in again, there will be an error message."

Yet in the animated gif you posted, I didn't see an error. Nor were we able to repro any error using the date you used.

Also, shouldn't "high priority" only be used for cases where a bug causes the system to crash, etc? In this case, it just seems to be a case of bad data, which doesn't hinder the app in terms of stability, etc

@smarkandu Sorry, I made a mistake. This is the real one: My intention is that the birthday after the current day is not valid. It is a bug with low priority.

[liuwei-tianshu]

The blue color made me confused. I thought it indicates that the value input is invalid. Actually, it indicates that the value comes from input history. That is why I made a mistake. Sorry.

[liuwei-tianshu]

@smarkandu "I label it as a high priority because when that doctor signs in again, there will be an error message."

When I sign in using that account, I just input the user name instead of email. So this bug is duplicate to #280

[liuwei-tianshu]

You are right. The crash must be a bug with high priority.

However, other situations may also be labeled as a high priority, especially when it blocks the usage of the workflow. The end-user does not have a strong background in computer science and patience/sufferance to try on the web pages if they face any problems. Any problems in the workflow may give end-users a bad impression to use it anymore. The end-user may input any value arbitrarily. That is why your team should test the workflow carefully.

The bugs with low priority usually do not affect the functionality of the system.

[smarkandu]

Right, but does this bug block/break the workflow for signing up? I don't think it does (user can register successfully), hence I think it should most likely be normal priority for this bug.

Also as a side note: bear in mind that right now we're focusing on getting all of the functionalities done first. Once this has been completed, we do plan on going over everything and locking down what can be inputted, who can do what, etc.

[liuwei-tianshu]

Actually, all functionalities that have been implemented should be tested comprehensively during each sprint. We do not demand the testing in the first sprints because it is not deployed online due to time constraints. My personal suggestion is to test it ASAP. I will share the link of the system with other TAs when we have the meeting to adjust the grades.

[MarwaKhalid]

Hi @liuwei-tianshu ,

You mentioned earlier in this issue that the name of the patient should be adjusted to indicate it's a linkable. Is this better?

[liuwei-tianshu]

Hi @liuwei-tianshu ,

You mentioned earlier in this issue that the name of the patient should be adjusted to indicate it's a linkable. Is this better?

I think it looks much better now. You can make your decision about it by yourself. I just report this bug to show that the system still has many defects/bugs and it needs more testing. Usually, when we find bugs, there must be more bugs underneath.

[AliZ786]

This was not really a bug @liuwei-tianshu more of a suggestion you made. Which is why we asked you.

[liuwei-tianshu]

@AliZ786 No problem to ask questions. Communication will help the project.

Yeah. It is hard to say it is a bug. The end-user is not familiar with the system and does not know it is linkable and may miss that feature. You can name it as a defect/missing feature or something and it does not matter.

However, the QA MUST report it because the quality includes usability and stability. This is how the QA works. They need to report everything abnormal they find. It is the QA's duty. After that, the developers can fix the bugs with high priority first. The QA drives the team to improve the quality of the system. Otherwise, no one will improve the quality.

I just want to show that the system still needs testing by QAs and show how the QA works.

[liuwei-tianshu]

The developer may not fix some bugs with low priority or due to time constraints. It is good and it happens a lot.

However, the QA must test it carefully and report everything.