Closed johnkiddjr closed 1 year ago
I have no issues with the actual content of this pull request, so on that front, this is approved, but as per coveralls' comment above, the lack of unit tests for the enumeration and string values has resulted in coverage decreasing, which I'd rather avoid, if you wouldn't mind writing a couple tests to cover those cases -- though they really don't need it, it's easier to just enforce the rule of "test as high a percentage of the codebase as possible" rather than making case-by-case decisions.
Agreed, added tests to ensure ToString and StringValue are equal (done for both TomlString and TomlLong) and tests to check that iterated values are the same as values pulled directly from the dictionary.
Appreciate it! Assuming this CI run passes fine, I'll merge this then.
Right well the explicit interface implementation wasn't covered but I can live with that, merging.
Fixes #27
This adds the functionality of IEnumerator to TomlTable, allowing you to iterate on the table without needing to reference the Entries property.
Becomes
This also adds an override on the ToString method for TomlValue to return the StringValue property.
Becomes