Samreay / ChainConsumer

Corner plots, LaTeX tables and plotting walks.
https://samreay.github.io/ChainConsumer
MIT License
82 stars 18 forks source link

[Bug] Wrong count of `walkers` after the chain division #108

Closed snwnde closed 12 months ago

snwnde commented 1 year ago

https://github.com/Samreay/ChainConsumer/blob/2461153bb3cdf8e75f03befeba095fac57eca203/src/chainconsumer/chain.py#L315-L318

The argument walkers is not excluded after the chain division, so that at the creation of the child chain, the validator would wrongly check the length of the child chains against the parent walkers.

The example in the current documentation https://samreay.github.io/ChainConsumer/generated/gallery/advanced_examples/plot_3_divide_chains/ doesn't pose a problem due to an unfortunate coincidence: 10000 is still an integer multiple of 4.