Closed melg8 closed 4 years ago
Thank you for the report. I'll take a look at this after work.
Adding coverage for more compilers is a great idea.
I've fixed the build for 17, and added g++-7 and clang++-7 to Travis.
Great! Thanks for fast response.
When changing in CMakeLists.txt cxx standard in cmake like this:
set(CMAKE_CXX_STANDARD
17)
And compiling with:On latest devel commit Observe an error in choice.hpp:55:
I think it happens because absl fallback to std implementation of visit and variant when c++17 is enabled (look for ABSL_USES_STD_VARIANT). So basically variant_internal::VisitResult doesn't exists in that case.
I don't know best solution, but what i can suggest:
Off topic: i think it will be great to add some checks to ci - to prevent any regression in standard support.