search

Samuel-Tyler / fast_ber

A C++11 ASN.1 BER Encoding and Decoding Library
Boost Software License 1.0
84 stars 11 forks source link

[8] Implement Set Decoding #33

Closed Samuel-Tyler closed 3 years ago

Samuel-Tyler commented 4 years ago

8

Allows SET type to be decoded with elements in arbitrary order.

Ensures that mandatory types are specified exactly once, and optional types are specified zero or one times.

benys commented 4 years ago

In my opinion you should also test SET with *** option (skip unknown tags)

Samuel-Tyler commented 4 years ago

That's a good suggestion, I'll add it, thanks

Samuel-Tyler commented 4 years ago

In my opinion you should also test SET with *** option (skip unknown tags)

I've added logic, and a test case here: https://github.com/Samuel-Tyler/fast_ber/blob/b13a40f9c2c64ea23943e9e012b7e901d4c801cc/test/generated/SetTest.cpp#L170

Please let me know if you have any other comments.

Also, I'd like to hear about your usage of ASN/BER, and if you have any other suggestions for improvements to the library?