attempt to fix start frame being greater than end frame

SanniM3 / video_summarisation_git

GIT with scene change based frame sampling

MIT License

2 stars 0 forks source link

attempt to fix start frame being greater than end frame #25

Closed uoefeb closed 1 year ago

uoefeb commented 1 year ago

@ip342 For some reason there were two "if len(sentences)" stacked on top of each other (but not nested). I'm not sure if this was a typo caused by editing the file during different sittings, or if it was intentional. It was causing some weird behavior where the start frame was after the end frame. I don't really understand why. That said, removing the redundant if seems to fix it. Could you please take a peek to make sure I've not done anything silly?

uoefeb commented 1 year ago

@ip342 I've looked at this a bit longer. I think I understand.

The idea was to:

first try with the adaptive detector
fall back to the content detector if there was only one scene
fall back again to random detection if there was still only one scene

is that right?

uoefeb commented 1 year ago

This PR is wrong. Closing.