Fan alias feature - Githubissues

SasaKaranovic / OpenFanController

Open-source open-hardware PC fan controller for everyone!

https://sasakaranovic.com/projects/openfan-controller/

GNU General Public License v3.0

126 stars 12 forks source link

Fan alias feature #12

Closed Th3M1k3y closed 2 months ago

Th3M1k3y commented 4 months ago

It would be nice to have the ability to rename fans in the UI.

Maybe something like Alias _{(FAN #1)}

Control through the API remain as it is currently.

SasaKaranovic commented 4 months ago

Thanks for the suggestion! I like this idea.

lord-xeon commented 4 months ago

I also would like this feature. I started to build something to keep track of the same for me. While it's probably not a problem for everyone, it's nice to know Fan 6 is the one on the top of the case.

SasaKaranovic commented 4 months ago

@Th3M1k3y @lord-xeon

I have just created a new branch https://github.com/SasaKaranovic/OpenFanController/tree/sk_general_improvements that contains API paths that allow setting of fan alias (name).

The UI is also updated to show aliases (if set). To set an alias, you would double-click on the fan name and the pop-up will appear asking for new fan name.

If you have the chance, please give it a try and let me know if you have any suggestions. I will take couple of days to test and make sure there are no issues or regressions and then if everything looks alright merge it into master.

Th3M1k3y commented 4 months ago

I am running the controller in the unraid docker, not sure how to go about testing this.

SasaKaranovic commented 4 months ago

I am running the controller in the unraid docker, not sure how to go about testing this.

You would have to run it manually or build a new docker image. It's ok if it's not convenient for you, I will release a new docker image once it's tested and then you can just update your container.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 3 days.

SasaKaranovic commented 3 months ago

This feature should be live now in the release branch. If you update (force-update) your docker image, you should have this option. Double-click on the fan name will show a prompt to enter a new fan name.

Let me know how it works and if you encounter any issues.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 3 days.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 3 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 5 days with no activity.