search

SasanLabs / VulnerableApp

OWASP VulnerableApp Project: For Security Enthusiasts by Security Enthusiasts.
https://sasanlabs.github.io/VulnerableApp/
Apache License 2.0
286 stars 380 forks source link

Add unit test for Error based SQL Injection #394

Open preetkaran20 opened 1 year ago

preetkaran20 commented 1 year ago

Is your feature request related to a problem? Please describe. We are looking at increasing the Test coverage for the project for its stability so this task is to add junit tests for https://github.com/SasanLabs/VulnerableApp/blob/master/src/main/java/org/sasanlabs/service/vulnerability/sqlInjection/ErrorBasedSQLInjectionVulnerability.java

preetkaran20 commented 1 year ago

Parent issue: https://github.com/SasanLabs/VulnerableApp/issues/212

13Anthony commented 11 months ago

Hi, is this issue still available? I would like to work on it

preetkaran20 commented 11 months ago

Hi @13Anthony,

Yes this issue is available. Assigning the ticket to you.

thanks, Karan

13Anthony commented 10 months ago

Hi, I've added tests, but I'm not able to push my changes. I got this error: remote: Permission to SasanLabs/VulnerableApp.git denied to 13Anthony. fatal: unable to access 'https://github.com/SasanLabs/VulnerableApp.git/': The requested URL returned error: 403 I generated token in github with all permissions and created my own branch too. Do you have any idea where the problem can be?

Thank you in advance.

preetkaran20 commented 10 months ago

@13Anthony you need to create a fork and from fork you need to create the pull request. Direct PR creation via branches is not allowed.