search

SasanLabs / VulnerableApp

OWASP VulnerableApp Project: For Security Enthusiasts by Security Enthusiasts.
https://sasanlabs.github.io/VulnerableApp/
Apache License 2.0
261 stars 357 forks source link

Fix SSRFVulnerabilityTest to mock the network calls. #445

Closed preetkaran20 closed 8 months ago

preetkaran20 commented 9 months ago

Is your feature request related to a problem? Please describe. SSRF vulnerability test is doing the network calls while running tests and causing failures. Reported issue: https://github.com/SasanLabs/VulnerableApp/issues/443

Describe the solution you'd like We would like to mock the network call such that these failures can be handled.

@bperry-mf @000panther

Vijay-948 commented 8 months ago

can you assign me?

tkomlodi commented 8 months ago

@Vijay-948, I've already have a fix if you haven't gotten started yet. If you prefer, I can also just send you what I have.

@preetkaran20, I should have probably signaled before getting started. In either case, I can contribute it or just throw it away.

Thanks

Vijay-948 commented 8 months ago

"No problem at all. I appreciate your willingness to contribute. Please go ahead.

preetkaran20 commented 8 months ago

Thanks a lot for the PR @tkomlodi. I have merged the changes.

tkomlodi commented 8 months ago

@preetkaran20, thanks for accepting the fix! I've been using OWASP tools for many years so I'm happy I can give back in a very modest way. I'll see if I can pick up some more issues. Thanks

preetkaran20 commented 8 months ago

@tkomlodi thanks and sure, please go ahead.