SchildiChat / schildichat-android-next

Matrix client / Element X fork
https://schildi.chat/android/next/
Apache License 2.0
53 stars 2 forks source link

Unread filter seemingly flag not respected #7

Closed niebloomj closed 3 months ago

niebloomj commented 3 months ago

Describe the bug I have the chat filter header showing and whether or not I select unread only chats, it's showing me unread first.

To Reproduce Quick settings Add chat filter header Click unread Click unread again Still only seeing unreads

Expected behavior I would think the unread button works like the favorite button. When I click filter by favorites it shows up at the top, and when I deselect it the favorites go down to be sorted by time. I would think unreads should work similarly.

Smartphone (please complete the following information): Pixel 6Pro on Android 14

Additional context

Upstream relevance

Add any other context about the problem here.

SpiritCroc commented 3 months ago

A filter is something else than a sort order.. There is currently no setting to not order by unread.

niebloomj commented 3 months ago

I had a feeling that was the case. Thanks 👍

SpiritCroc commented 3 months ago

FWIW, the "chat list filters" were added by Element and I don't like their UX at all so far, so likely I won't touch these. Settings to change the sort order are likely something worth considering (may be worth a separate issue), even though sliding sync makes these a bit more complicated, if we do not want to experience too many empty room previews.