search

Scrimmage / karma-slim-preprocessor

Compiles slim to html for karma tests
MIT License
5 stars 6 forks source link

Adding in caching #5

Open sb8244 opened 7 years ago

sb8244 commented 7 years ago

Would you be interested in receiving a local file storage caching mechanism in this project? I implemented to improve independent karma startup performance and was able to cut processing from 90s to 3s.

It is based on the node-localcache project w/ md5 content hash of the originalPath file vs the output HTML.

ratbeard commented 7 years ago

That sounds cool @sb8244. We're in the process of switching our projects over to using pug, which slim was renamed to a little while back. I moved one of our apps over to https://github.com/StoutLLC/karma-ng-pug2js-preprocessor last week, so I'd probably make the change there as its more actively maintained. But would accept a patch here if you sent one.

sb8244 commented 7 years ago

Was slim renamed to pug, or Jade?

Long term I'm also moving in that direction. I'll look to add that caching here in the short term. On Wed, Oct 12, 2016 at 8:52 AM Mike Frawley notifications@github.com wrote:

That sounds cool @sb8244 https://github.com/sb8244. We're in the process of switching our projects over to using pug, which slim was renamed to a little while back. I moved one of our apps over to https://github.com/StoutLLC/karma-ng-pug2js-preprocessor last week, so I'd probably make the change there as its more actively maintained. But would accept a patch here if you sent one.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Scrimmage/karma-slim-preprocessor/issues/5#issuecomment-253204669, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLLK6EzeWCHsOE_2OFqZpja3_SjwCuqks5qzNf5gaJpZM4KUUkC .

ratbeard commented 7 years ago

Hah, yea you're right, it was jade that was renamed to pug. They're both so similar, for a while I was compiling a file under both tools successfully, nodejs+jade for frontend development and rails+slim for deployment.

Sounds good 👍