search

Seeneva / seeneva-reader-android

A libre smart powered comic book reader for Android.
https://seeneva.app
256 stars 20 forks source link

Libarchive and CBR #23

Open Zellius opened 3 years ago

Zellius commented 3 years ago

I checked the issue #11. It seems there is a Libarchive RAR archive limitation described here libarchive/libarchive#373. That means that some CBR comic books are not fully supported by Seeneva right now. Some comic book pages can be silently ignored by the app. The error of ignored pages is Parsing filters is unsupported.

As a simple workaround for current app version is to repack corrupted CBR files into CBZ and add it to the app.

I should think how to fix this in future versions. It seems that Linux viewers (like Okular) use the unrar library to open CBR books. I should check its license because I have no other way but static link it into the libseeneva.so.

linsui commented 2 years ago

The unrar is licensed under a non-foss license and will be blocked by F-Droid. If you are going to add it, could you please exclude it from fdroid flavor? Thanks!

Zellius commented 2 years ago

@linsui I don't have any plans to include any non-foss dependencies, even to Google Play version. All flavours of the app will always be completely FOSS :slightly_smiling_face: My last thoughts were about to build a separate "plugin" apk with build-in unrar library and different license. But I didn't research it yet ...

linsui commented 2 years ago

That's great! And the refered libarchive issue seems solved so maybe unrar is not needed.