search

SeitaBV / flexmeasures-openweathermap

Integration to the OpenWeatherMap API from FlexMeasures.
Apache License 2.0
4 stars 1 forks source link

Allow storing both cloud cover and irradiance #5

Closed create-issue-branch[bot] closed 2 years ago

create-issue-branch[bot] commented 2 years ago

closes #4

Flix6x commented 2 years ago

@nhoening Can you assist with the pipeline error? I believe we encountered this before?

No local packages or working download links found for backports-zoneinfo==0.2.1
nhoening commented 2 years ago

Sometimes this goes away as it's on GH side. Let's run the job again and if it still fails, wait two hours and run once more.

nhoening commented 2 years ago

The problem seems to persist. I checked, and FlexMeasures isn't requiring that package anymore, also not the actual package zoneinfo. So I'm thinking we could update requirements.txt and see if that still happens. Will do that later today.

nhoening commented 2 years ago

If #6 lands well, we could merge main in here and that should help.

Flix6x commented 2 years ago

I'm having trouble figuring out why this last test is failing. Care to take a look? When I manually run the CLI command for registering a new weather sensor twice, I get the expected behaviour.

nhoening commented 2 years ago

Your new code in this PR mutates sensor_specs.mapping (via a pop() call), and the test runs the command twice in one session, re-using the mutated settings. I believe that was the reason for the difference of you running it twice manually.

I believe my edit helps to keep sensor_specs.mapping in its natural state.

Flix6x commented 2 years ago

Thank you!