Sereni / Simply-Love-SM5-Vertical

Simply Love on vertical screens
MIT License
13 stars 3 forks source link

Merge Simply Love 4.9 #64

Closed Roujo closed 4 years ago

Roujo commented 4 years ago

Things to check:

Fixes #56

Sereni commented 4 years ago

Went through screens up to ScreenSelectMusic, and Player/Service options. Evaluation, evaluation summary, and name entry screens need attention.

Sereni commented 4 years ago

Tidied ScreenEvaluation a bit and looked at others. There are a few more issues remaining:

Roujo commented 4 years ago

TestInput pane was possibly never ported to vertical? Need to check and fix

I don't remember seeing it in the evaluation screen, in any case. It would be nice to have! ^^

QR code pane is gone and I can't figure out where D:

I remember that part of the merge, I'll give it a look soon. =)

Roujo commented 4 years ago

Two more items:

Sereni commented 4 years ago

Thanks for flagging! The score had space because the correct size was lost in the merge. Brought it back. With this size, there's no space. I don't see toooo much value in the letter grade and I think it needs its own large area if we were to include it, otherwise it'd look crowded with the score. Prefer to keep it off for now.

Screen Shot 2020-07-15 at 5 44 38 AM image

Sereni commented 4 years ago

Merging this now and following up on the rest of the issues in dev.

Thanks Roujo!

Sereni commented 4 years ago

@Roujo I had some fun finding the combo and hold previews. Got down to this: calls to SCREENMAN:GetTopScreen() in Graphics/OptionRow Frame.lua return nil if we're in the 2nd player options screen, but work correctly on the 1st screen.

I also just realized that ExportOnChange doesn't work on the 2nd screen for some reason, which would make previews only update on Enter :( in addition to already breaking a few of our rows there.