search

Serhioromano / vscode-gitflow

Git Flow extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=Serhioromano.vscode-gitflow
MIT License
42 stars 9 forks source link

the characters # are supported when creating gitflow branch names #37

Closed romanholidaypancakes closed 2 years ago

romanholidaypancakes commented 2 years ago

image

Sometimes fix#123456 is used to fix a problem, and #1 can help us locate the problem, so this character should not be banned, nor does git itself ban this character

github-actions[bot] commented 2 years ago

Welcome!

Thank you for finding time to write an issue and help to make this extension better. I`ll appreciate if you find some time to rate this extension here.

I`ll get to this Issue ASAP.

Serhioromano commented 2 years ago

If you add this to a comment of a fix like fix#123456 it will also do the same. Also, it is good practice to use a new version as a name for hotfix so that your application version tag is properly created.

Anyway I change the name check to any fully valid git branch name and in the comment I add also this issue so you will see how in a comment automatically works.

Serhioromano commented 2 years ago

I pushed version 1.3.11 it should work there. Should be available in market in a few minutes. Please, rate this extension if you few moments of time. https://marketplace.visualstudio.com/items?itemName=Serhioromano.vscode-gitflow&ssr=false#review-details

romanholidaypancakes commented 2 years ago

commented👍