Upon coredump (crash) plugin reports 0 return

[shrkamat]

Bug description Upon coredump (crash) plugin reports 0 return. It's easily misinterpreted for run step to be success.

Steps to reproduce

git clone git@github.com:shrkamat/NvimCMakePluginTest.git
cd NvimCMakePluginTest
vim test.cpp
:CMake configure
:CMake build_and_run

Minimal configuration

Expected behavior Should report non-zero value upon failure and crash.

Screenshots

Environment

• OS:

  lsb_release -a
  Distributor ID: Ubuntu
  Description:    Ubuntu 20.04.2 LTS
  Release:        20.04
  Codename:       focal

• Desktop environment:

• Plugins commit hash:

  cd $HOME/.local/share/nvim/site/pack/packer/start/neovim-cmake
  git log
  commit f4bb9996dce8b156f9e2026bf2ffa7abbb087b86 (HEAD -> master, origin/master, origin/HEAD)
  Author: thomasmore <mcbolsh@gmail.com>
  Date:   Mon Feb 28 00:41:35 2022 +0300
  
  Implement config options to customize quickfix and output behaviour (#26)
  
  * Add option to not open quickfix window on successfull build
  * Add on_output callback to track cmake progress

  Additional context

[Shatur]

Thanks for the report! I noticed that it works correctly (exists with code 1) if I comment out this part:

TEST(NvimCMakePlugin, ReportsFailedTestCorrectly) {
    int divisor = 0;
    ASSERT_EQ(10, 100/divisor);
}

The following program is also exits with the expected exit code:

int main()
{
    return 1;
}

I use exit codes that returned by Plenary.Job, so I assume that it's an upstream issue.

[Shatur]

Opened: https://github.com/nvim-lua/plenary.nvim/issues/331

[shrkamat]

Thanks @Shatur. This fixes the issue, but I don't see complete crash log in CMake build_and_run output.

In shell I see this extra info Floating point exception (core dumped) , so it's not super explicit about crash. (exit code 136 vs crashed exit 136).

[Shatur]

In shell I see this extra info Floating point exception (core dumped)

Not sure why it not displayed... I catching all stdout and stderr.

[shrkamat]

Yes indeed both stderr and stdout is captures. Looks like is something to do with the shell (see last arg to subprocess.Popen).

#!/bin/python3

import subprocess

def print_lines(lines):
    if lines:
        print(lines.decode('utf-8'))
    else:
        print('None\n')

p = subprocess.Popen('./build/bin/nvim-cmake-plugin-test', stdout=subprocess.PIPE, stderr=subprocess.STDOUT, start_new_session=False, shell=True)
stdout, stderror = p.communicate()
p.wait();

print('shell=True-------------------------------')
print_lines (stdout)
print_lines (stderror)
print ('shell=True exit code', p.returncode)
print('-----------------------------------------')

p = subprocess.Popen('./build/bin/nvim-cmake-plugin-test', stdout=subprocess.PIPE, stderr=subprocess.STDOUT, start_new_session=False, shell=False)
stdout, stderror = p.communicate()
p.wait();

print('shell=False-------------------------------')
print_lines (stdout)
print_lines (stderror)
print ('exit code', p.returncode)
print('-----------------------------------------')

Output

shell=True-------------------------------
update : 0
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from NvimCMakePlugin
[ RUN      ] NvimCMakePlugin.ReportsNonZeroValueForFailedTest
/home/skamath/Projects/NVimCMakePluginTests/test.cpp:4: Failure
Value of: false
  Actual: false
Expected: true
[  FAILED  ] NvimCMakePlugin.ReportsNonZeroValueForFailedTest (0 ms)
[ RUN      ] NvimCMakePlugin.ReportsCrashedTestIncorrectly
Floating point exception (core dumped)

None

shell=True exit code 136
-----------------------------------------

shell=False-------------------------------
update : 0
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from NvimCMakePlugin
[ RUN      ] NvimCMakePlugin.ReportsNonZeroValueForFailedTest
/home/skamath/Projects/NVimCMakePluginTests/test.cpp:4: Failure
Value of: false
  Actual: false
Expected: true
[  FAILED  ] NvimCMakePlugin.ReportsNonZeroValueForFailedTest (0 ms)
[ RUN      ] NvimCMakePlugin.ReportsCrashedTestIncorrectly

None

exit code -8
-----------------------------------------

With shell=False even the exit code looks very different. Not sure what to infer from this.

[Shatur]

Can't help you here, Plenary don't have such option: https://github.com/nvim-lua/plenary.nvim/blob/9069d14a120cadb4f6825f76821533f2babcab92/lua/plenary/job.lua#L6

[shrkamat]

No issues, thanks for the plugin. It makes nvim much closer to IDE like experience. Appreciate it. Thanks.