Shatur / neovim-cmake

CMake integration for Neovim
GNU General Public License v3.0
87 stars 19 forks source link

Position of the quickfix window #36

Closed Perry3D closed 2 years ago

Perry3D commented 2 years ago

Describe the problem or limitation you are having If I open the quickfix window manually i can do something like :top copen to specify the position of the window.

Describe the solution you'd like A configuration option to specify the position of the quickfix window. Maybe something like this:

require('cmake').setup({
  quickfix_pos = 'top'
})
Shatur commented 2 years ago

Agree, but since we also have quickfix_height and quickfix_only_on_error, I think we should introduce quickfix option and and put other quickfix-related parameters into it:

require('cmake').setup({
  quickfix = {
    pos = 'buttom',
    height = 10,
    only_on_error = false,
  }
})
yucongxing commented 2 years ago

Agree, but since we also have quickfix_height and quickfix_only_on_error, I think we should introduce quickfix option and and put other quickfix-related parameters into it:

require('cmake').setup({
  quickfix = {
    pos = 'buttom',
    height = 10,
    only_on_error = false,
  }
})

how about "auto focus on the quickfix window", i cant find the configure now.

Shatur commented 2 years ago

how about "auto focus on the quickfix window", i cant find the configure now.

I don't see any use case for it. You can navigate quickfix items using :qnext or use awesome vim-unimpaired.

yucongxing commented 2 years ago

how about "auto focus on the quickfix window", i cant find the configure now.

I don't see any use case for it. You can navigate quickfix items using :qnext or use awesome vim-unimpaired.

thanks for your reply! there are some reasons for my suggestion. firstly, it inconvenient to close the quickfix window after run CMake commands. i need to navigate to it and closed. secondly, i see the future feature(https://github.com/Shatur/neovim-cmake/pull/35) about interact with the quickfix window (maybe a built-in terminal), if the feature is implemented, "auto focus" may become a needed configure.

Shatur commented 2 years ago

i need to navigate to it and closed.

I personally have a keymap which toggle quickfix. And I would recommend to use something like this instead.

interact with the quickfix window

It's impossible to interact with quickfix window. If it will be a built-in terminal - it's different and not related to quickfix.

yucongxing commented 2 years ago

i need to navigate to it and closed.

I personally have a keymap which toggle quickfix. And I would recommend to use something like this instead.

interact with the quickfix window

It's impossible to interact with quickfix window. If it will be a built-in terminal - it's different and not related to quickfix.

thanks a lot for you patience.