Shatur / neovim-cmake

CMake integration for Neovim
GNU General Public License v3.0
87 stars 19 forks source link

Allow users to customize dap configurations #6

Closed spindensity closed 3 years ago

spindensity commented 3 years ago

Describe the problem or limitation you are having

The dap configurations are hardcoded: https://github.com/Shatur/neovim-cmake/blob/2b37c4a1b3374d9eef943aaeee6882d97675b6e6/lua/cmake/init.lua#L74-L83

The hard-coded configurations could not deal with adapters with server type which need host and port properties, such as CodeLLDB, see https://github.com/mfussenegger/nvim-dap/issues/307#issuecomment-927100276. If you use adapters with server type, an error would be raised:

Snipaste_2021-09-30_13-19-39

Describe the solution you'd like

Allow users to customize dap configurations

Shatur commented 3 years ago

Totally agree, will add configuration for this after work. Or you can speedup the process by sending a PR for it :)

spindensity commented 3 years ago

Totally agree, will add configuration for this after work. Or you can speedup the process by sending a PR for it :)

OK, I'll send a PR.

spindensity commented 3 years ago

Done.