search

Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

chore(circleci): Allow qa to bypass awesome_bot check #272

Closed michaelachrisco closed 3 years ago

michaelachrisco commented 3 years ago

Changes

  1. QA links should bypass awesome_bot checks

Purpose

QA links are currently causing awesome_bot to fail. In general awesome_bot can only check public links.

Approach

Add QA links to the allowlist.

Closes #271

michaelachrisco commented 3 years ago

Is there a way to manage this that doesn't require so much upkeep?

It would require https://github.com/dkhamsing/awesome_bot to support private github urls or we blanket add Shift3 to the allowlist. We tried to add Shift3 to the allowlist but led to a link being missed by the tool. The asesome_bot repo no longer has an issue section which is a bad sign.

I am open to suggestions! awesome_bot is still providing value by letting us know if the links are broken, but its tripping up reliably on private repo/url links. I thought if we had a running list of private urls, this sort of false positive would only occur from time to time, but that assumption is now proving to be incorrect. Any new private link has to be added to the circleci/config.yml file which is time consuming.