search

Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

docs(README): expand Gitflow explanation w/ diagram #300

Closed amerikan closed 2 years ago

amerikan commented 2 years ago

Changes

List Changes Introduced by this PR

  1. Expand on how Gitlfow workflow works
  2. Add visual diagram

Preview: https://github.com/amerikan/standards-and-practices/blob/main/README.md

amerikan commented 2 years ago

@amerikan Can you do me a favor and push this upstream onto this repo? There is some niceties we get from Circleci checking all new links and Danger checking all new PRs for formatting/content. And can you create an issue to close out?

Otherwise changes look good to me. Thanks for adding that graphic (such a classic) and adding more concise gitflow instructions.

@michaelachrisco don't have permissions to do that directly so that's why I have been working off a fork 😄

michaelachrisco commented 2 years ago

@amerikan Can you do me a favor and push this upstream onto this repo? There is some niceties we get from Circleci checking all new links.

@amerikan Can you do me a favor and push this upstream onto this repo? There is some niceties we get from Circleci checking all new links and Danger checking all new PRs for formatting/content. And can you create an issue to close out? Otherwise changes look good to me. Thanks for adding that graphic (such a classic) and adding more concise gitflow instructions.

@michaelachrisco don't have permissions to do that directly so that's why I have been working off a fork smile

You know what? This is silly. I gave you write access to the repo. Apologies that took so long. Thought you would be part of the PR team by now. Let me know if you continue having issues.

amerikan commented 2 years ago

@amerikan Can you do me a favor and push this upstream onto this repo? There is some niceties we get from Circleci checking all new links.

@amerikan Can you do me a favor and push this upstream onto this repo? There is some niceties we get from Circleci checking all new links and Danger checking all new PRs for formatting/content. And can you create an issue to close out? Otherwise changes look good to me. Thanks for adding that graphic (such a classic) and adding more concise gitflow instructions.

@michaelachrisco don't have permissions to do that directly so that's why I have been working off a fork smile

You know what? This is silly. I gave you write access to the repo. Apologies that took so long. Thought you would be part of the PR team by now. Let me know if you continue having issues.

Don't think I'm part of PR team, but I do now have write access to this repo 👍🏼

amerikan commented 2 years ago

Closing in favor of https://github.com/Shift3/standards-and-practices/pull/301