Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

docs(README): expand Gitflow explanation w/ diagram #301

Closed amerikan closed 2 years ago

amerikan commented 2 years ago

Changes

List Changes Introduced by this PR

  1. Expand on how Gitlfow workflow works
  2. Add visual diagram
Shift3PullRequestBot commented 2 years ago
3 Warnings
:warning: Please link to a GitHub issue within this pull request. Example: Closes #9999
:warning: Please add a Purpose section to your Pull Request description.
:warning: This Pull Request does not have any assignees yet. You may want to assign yourself if this is your Pull Request.

Generated by :no_entry_sign: Danger

amerikan commented 2 years ago

Thanks @amerikan ! Everything looks good. The only thing we are missing from this PR is a referenced issue. If you can add that, we should be good here.

@michaelachrisco There is no issue for this. The PR template says only to add if there is one, otherwise to remove that line. I only suggested this PR because I saw room for improvement in that section 😄

Screen Shot 2021-10-12 at 9 55 17 AM
michaelachrisco commented 2 years ago

Wow this whole time, I thought it stated to always reference an issue! OK this is a great topic that I would like the whole shop to weigh in on. For now though, this PR totally compliant.