Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

docs(github template): fix feature_request template #314

Closed amerikan closed 2 years ago

amerikan commented 2 years ago

Changes

List Changes Introduced by this PR

  1. Removes invalid Github template values

Purpose

Fix invalid yml values and missing references

Test Case

See https://github.com/amerikan/standards-and-practices/issues/new/choose

If this closes an issue, name it here. If it doesn't, remove this line Closes #313

amerikan commented 2 years ago

@michaelachrisco should be good now. Assignee and Value fields can't be empty. 🤭

michaelachrisco commented 2 years ago

@amerikan Looks like there is references to our old https://github.com/Shift3/standards-and-practices/blob/main/.github/ISSUE_TEMPLATE/feature_request.md within the repo. Its currently causing some 404s to pop up via our READMEs as well as breaking the CircleCI builds.

Can you take a look and switch .md to yml?

amerikan commented 2 years ago

@michaelachrisco I tried to grep but I can't find any, do you have list of files where they are?

michaelachrisco commented 2 years ago

@michaelachrisco I tried to grep but I can't find any, do you have list of files where they are?

I believe this is the only one, I just tried to use github search...and nothing came up 🤷 . The CI process awesome_bot flagged the below:

https://github.com/Shift3/standards-and-practices/blob/main/standards/issue-template.md

There is a link to the Feature Request page.

Shift3PullRequestBot commented 2 years ago
1 Warning
:warning: Please add a Purpose section to your Pull Request description.

Generated by :no_entry_sign: Danger

michaelachrisco commented 2 years ago

1 Warning warning Please add a Purpose section to your Pull Request description.

Generated by no_entry_sign Danger

Go home bot your drunk :laughing:

I have no idea why its not detecting your purpose section. If it does this again, im going to have to take a look.