search

Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

fix(#368): Fix moves View On Github button below the sidebar nav #359

Closed markrogers9109 closed 2 years ago

markrogers9109 commented 2 years ago

Changes

  1. Adds custom styles
  2. Updates dependencies

Purpose

The View On Github button was covering the content. Issue 358

Approach

Adds custom CSS to override theme button styles

Pre-Testing TODOs

Testing Steps

Learning

Troubleshoot how the styles are being rendered on the gh-pages site. Find documentation on how to add custom styles to override the leap-day theme. Find out how to test the site locally to verify your changes are working before you push up the changes. Troubleshoot any errors encountered when trying to serve the site locally.

michaelachrisco commented 2 years ago

We have had that issue out for sooo long! Super excited to see what the changes are.

Is there a url that we can see to test this out? A screenshot of the change within the PR description would help others so they dont need to install ruby to review the PR if you dont mind.

markrogers9109 commented 2 years ago

I don't have a link, but this is an image of what it will look like. vog-button-new-location

michaelachrisco commented 2 years ago

I pulled it down, looks great! Thanks so much for getting that to work. Ill approve and let others review when the get the chance. Awesome job!

markrogers9109 commented 2 years ago

Thanks!