Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

docs(accessibility readme): resolve typos and grammatical errors #368

Closed STRussell0 closed 1 year ago

STRussell0 commented 1 year ago

Changes

  1. Correct grammatical errors and typos on README doc

Purpose

Multiple grammatical errors and a couple typos

Pre-Testing TODOs

N/A

Testing Steps

Read over README doc

Closes #367

STRussell0 commented 1 year ago

I attempted to clone the repo and push a new branch up, but I received a permission error. I decided to fork the repo instead and try to create a PR from the fork, but there appears to be a new error here I am unfamiliar with. :sweat_smile:

michaelachrisco commented 1 year ago

What permission error did you get @STRussell0 when creating a branch?

A fork (like you did) will work as well for our public repos. Our standard is to create a branch, so if its coming from our internal BW developers, we should try and get that working.

STRussell0 commented 1 year ago

I think Ethan may have gone over the issues we were running into earlier on his PR in regards to permissions, but it seems that I am now able to add reviewers and would probably be able to push my branch (not the forked version) up for a merge, though I am uncertain if that is necessary at this point.

Went ahead and added the @Shift3/pr-team account as a reviewer as requested, but was not able to see the example you shared. Link takes me to a 404 error. Let me know if there is anything you'd like me to do for this!

Thanks!