Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

feat(#369, code-reviews): Add additional resource links #370

Closed EthanKFoster closed 1 year ago

EthanKFoster commented 1 year ago

Changes

  1. add link to BWTC dev connect on code review
  2. add link to Google article emphasizing code review speed

Purpose

369

This pr adds links to the resources section of the code review page. Applicable outside information was found that could be considered supplemental to our standards for code review, and find a good place here.

Approach

Additional links and resources bolster the strength of our standards, provided that the organization agrees with them.

Pre-Testing TODOs

NA

Testing Steps

View the links and assess their value in including them in our S&P repo.

Learning

Learning to navigate through the S&P and find places where I can contribute was the majority of this feature, and I'm looking forward to additional contributions I can make.

Closes #369

EthanKFoster commented 1 year ago

Hi @michaelachrisco!!

I opted for forking when my fellow onboarding podmate Stephen Russell mentioned difficulty in branching and pushing directly to this repo. Additionally, when I requested another review from Erik on the issue above, it removed the other reviewers automatically, which I didn't expect, and I'm currently not able to add the PR team to the reviewer section (at least in the way I'm familiar from doing the same in our pod).

I don't believe I have full collaborator access to this repo currently. I'm not able to add reviewers, assignees, labels, or any other features found in the sidebar.

EthanKFoster commented 1 year ago

@michaelachrisco Would the CircleCI plugin have been fine with forking if a branch had been made prior to the fork?

michaelachrisco commented 1 year ago

Hi @michaelachrisco!!

I opted for forking when my fellow onboarding podmate Stephen Russell mentioned difficulty in branching and pushing directly to this repo. Additionally, when I requested another review from Erik on the issue above, it removed the other reviewers automatically, which I didn't expect, and I'm currently not able to add the PR team to the reviewer section (at least in the way I'm familiar from doing the same in our pod).

I don't believe I have full collaborator access to this repo currently. I'm not able to add reviewers, assignees, labels, or any other features found in the sidebar.

Thanks for letting me know!

Can you try again now to update the PR tags, assignees, etc...? Looks like you and the new devs were not added to the PR-Team. You should now have full access to the repos now.

michaelachrisco commented 1 year ago

Awesome! Looks like that was the issue.

Ill make sure moving forward new devs are part of the PR-Team from day 1 (2?).

EthanKFoster commented 1 year ago

You rock, Mike! I appreciate your quick responses, definitely ramped up my own learning process in the beginning here. Thanks for the help 👍🏻