search

Shift3 / standards-and-practices

Standards and Practices for Bitwise Industries
https://shift3.github.io/standards-and-practices/
63 stars 41 forks source link

chore(standards): find and change web links to relative links #371

Closed funcyChaos closed 1 year ago

funcyChaos commented 1 year ago

a handful of links to other markdown files were linked https://github... This works fine on GitHub but not in VS Code nor is it consistent Changed all possible outliers to ./*.md

Changes

  1. Links to local markdown files changed from external(https://...) to local(./...)

Purpose

The links were difficult to navigate in VS Code and inconsistent with a majority of absolute or relative paths

Approach

Using relative paths to replace links found only inside standards

Pre-Testing TODOs

Testing Steps

Click on relevant links, observe navigation within preview

Learning

Didn't know you could link .md files and navigate them in this fashion

funcyChaos commented 1 year ago

I'll create an issue and get a branch made. Heads up the Day 1 handbook says "It's always a work-in-progress, so feel free to fork, and submit a PR", wasn't sure which way to go. We tried to branch and push and got a permission denied. Will submit shortly :grinning:

michaelachrisco commented 1 year ago

Well thats news to me! Thanks for the clarification. I wondered why everyone was forking. Also looks like you were not included to the PR-Team so giving you access should give you access for branching, adding tags to the PR, issues, etc...

I went ahead and added you to the PR team. Give it another shot.