Shinmera / qtools

Qtools is a collection of utilities to aid development with CommonQt
https://shinmera.github.io/qtools
zlib License
210 stars 17 forks source link

titter example creds #31

Closed juszczakn closed 6 years ago

juszczakn commented 6 years ago

I assume these twitter creds aren't valid, but might make sense to make it obvious they are invalid with a comment or somesuch?

https://github.com/Shinmera/qtools/blob/master/examples/titter/titter.lisp#L20

phoe commented 6 years ago

Why don't you simply (defvar *twitter-application-key*) ? That should force anyone using the code to set it for themselves.

July 27, 2018 5:28 AM, "Nick" <notifications@github.com (mailto:%22Nick%22%20notifications@github.com)> wrote: I assume these twitter creds aren't valid, but might make sense to make it obvious they are invalid with a comment or somesuch?

https://github.com/Shinmera/qtools/blob/master/examples/titter/titter.lisp#L20 (https://github.com/Shinmera/qtools/blob/master/examples/titter/titter.lisp#L20) 

—

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://github.com/Shinmera/qtools/issues/31), or mute the thread (https://github.com/notifications/unsubscribe-auth/AOWTqlHuNqyb4cPz6sazG43tLpvTJFGXks5uKojLgaJpZM4Vi28D).

Shinmera commented 6 years ago

They are valid.