search

Shinmera / qtools

Qtools is a collection of utilities to aid development with CommonQt
https://shinmera.github.io/qtools
zlib License
209 stars 17 forks source link

Some systems failed to build for Quicklisp dist #48

Closed quicklisp closed 1 year ago

quicklisp commented 1 year ago

Building with SBCL 2.3.1.43-c2e7dcbd6 / ASDF 3.3.5 for quicklisp dist creation.

Trying to build commit id 0f10649913ed74afa356b3ade9ed0d33aa779f33

q+ fails to build because of a failure in qtools.

qtools-evaluator fails to build because of a failure in qtools.

qtools-game fails to build because of a failure in qtools.

qtools-helloworld fails to build because of a failure in qtools.

qtools-melody fails to build because of a failure in qtools.

qtools-opengl fails to build because of a failure in qtools.

qtools-titter fails to build because of a failure in qtools.

qtools fails to build with the following error:

; caught ERROR:
;   READ error during COMPILE-FILE: The symbol "FUNCTION" is not external in the CL+QT package. Line: 106, Column: 24, File-Position: 4162 Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /home/quicklisp/quicklisp-controller/dist/build-cache/qtools/500e27aeb057a8fd6a9ecdf77aeb74f6410a02aa/qtools-20230205-git/dynamic.lisp" {10108D0433}>
...
Unhandled UIOP/LISP-BUILD:COMPILE-FILE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1001720003}>: COMPILE-FILE-ERROR while compiling #<CL-SOURCE-FILE "qtools" "dynamic">

Full log here

Shinmera commented 1 year ago

How bizarre. I can't reproduce on SBCL 2.3.1. Loading qtools flushes through just fine with :verbose T. The code in this has not changed in many years, either.

quicklisp commented 1 year ago

Hmm, I'm using newer than 2.3.1, maybe there's a package bug in it. I'll investigate more.

On Sun, Feb 5, 2023 at 8:15 AM Nicolas Hafner @.***> wrote:

How bizarre. I can't reproduce on SBCL 2.3.1. Loading qtools flushes through just fine with :verbose T. The code in this has not changed in many years, either.

— Reply to this email directly, view it on GitHub https://github.com/Shinmera/qtools/issues/48#issuecomment-1417811371, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLPSQCRHOE7SMF7QBMTWV6RYRANCNFSM6AAAAAAURXQFC4 . You are receiving this because you authored the thread.Message ID: @.***>

quicklisp commented 1 year ago

Doug Katzman pointed out that the current code runs afoul of http://l1sp.org/cl/3.6 with regard to traversing packages. He suggests replacing it with:

(let (list) (do-symbols (s "CL+QT") (push s list)) (export list "CL+QT"))

This allows qtools to compile again on the latest SBCL HEAD.

Zach

On Sun, Feb 5, 2023 at 8:48 AM Zach Beane @.***> wrote:

Hmm, I'm using newer than 2.3.1, maybe there's a package bug in it. I'll investigate more.

On Sun, Feb 5, 2023 at 8:15 AM Nicolas Hafner @.***> wrote:

How bizarre. I can't reproduce on SBCL 2.3.1. Loading qtools flushes through just fine with :verbose T. The code in this has not changed in many years, either.

— Reply to this email directly, view it on GitHub https://github.com/Shinmera/qtools/issues/48#issuecomment-1417811371, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLPSQCRHOE7SMF7QBMTWV6RYRANCNFSM6AAAAAAURXQFC4 . You are receiving this because you authored the thread.Message ID: @.***>