search

ShiqiYu / libfacedetection.train

The training program for libfacedetection for face detection and 5-landmark detection.
Apache License 2.0
774 stars 209 forks source link

[Docs] Visualization of network architecture points to older onnx file link #51

Closed kishore-s-15 closed 2 years ago

kishore-s-15 commented 2 years ago

Issue:

Link for visualization of YuNet architecture from the README file does not point to the correct onnx file. The current link points to the onnx file based on the previous directory structure.

Screenshot:

libfacedetection_readme_issue

Possible Fix:

Have to update the README file to point to the latest onnx file (From the 3 onnx files currently present).

Can I work on it and raise a PR ?

fengyuentau commented 2 years ago

Yes, we welcome pull requests.

kishore-s-15 commented 2 years ago

@fengyuentau Sure, I'll work on it. Out of the three model available here, which model do you want me to link or can I add all the three models to the README ?

fengyuentau commented 2 years ago

I would say the dynamic one is better for presenting. No need to list them all.

kishore-s-15 commented 2 years ago

I would say the dynamic one is better for presenting. No need to list them all.

Thanks, I'll add that model's link then.